rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stanton Sievers" <siever...@gmail.com>
Subject Review Request 17358: Cloning a page for the current user prompts them to accept/decline the page
Date Sun, 26 Jan 2014 00:35:40 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for rave.

Bugs: RAVE-1090

Repository: rave


If a page is cloned for the current user (which can be done via the REST APIs but not the
current Share Page UI) the user is prompted to Accept/Decline the page on first render. 

The fix is to check and see if the current authenticated user is the user for which the page
is being cloned.  If they are the same, set the page user status to "owned" instead of "pending".



Diff: https://reviews.apache.org/r/17358/diff/


Existing unit tests pass.

Verified that cloning a page for another user still results in the dialog.  Verified via Postman
that cloning the page for the authenticated user results in no prompt upon first render of
the page.

It's worth noting that I was having problems cloning pages with more than one region in the
default portal.  Things worked as expected with a single column page layout where there is
only one region.  Is this known behavior?  I did not encounter it when working on RAVE-1086.
 I encountered it even without this or any other patches.


Stanton Sievers

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message