rocketmq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vongosl...@apache.org
Subject [rocketmq-spring] branch master updated: Default choice is not allowed to merge
Date Thu, 26 Nov 2020 08:41:35 GMT
This is an automated email from the ASF dual-hosted git repository.

vongosling pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-spring.git


The following commit(s) were added to refs/heads/master by this push:
     new cf18bb1  Default choice is not allowed to merge
cf18bb1 is described below

commit cf18bb1ab68e28c67e72b37eadf3935979086793
Author: von gosling <vongosling@apache.org>
AuthorDate: Thu Nov 26 16:41:28 2020 +0800

    Default choice is not allowed to merge
---
 .github/PULL_REQUEST_TEMPLATE.md | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 5799172..9087fa0 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -12,9 +12,9 @@ XXXX
 
 Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
`it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before
request the community to review your PR`.
 
-- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a Github issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue. 
-- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config
not exist`. Each commit in the pull request should have a meaningful subject line and body.
-- [x] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
-- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more
mock a little better when cross module dependency exist. 
-- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make
sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run
`mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
+- [] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a Github issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue. 
+- [] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config
not exist`. Each commit in the pull request should have a meaningful subject line and body.
+- [] Write a pull request description that is detailed enough to understand what the pull
request does, how, and why.
+- [] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock
a little better when cross module dependency exist. 
+- [] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make
sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run
`mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
 - [ ] If this contribution is large, please file an [Apache Individual Contributor License
Agreement](http://www.apache.org/licenses/#clas).


Mime
View raw message