rocketmq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ifplu...@apache.org
Subject [rocketmq-client-nodejs] 01/01: fix: compile on linux and ci
Date Sun, 28 Mar 2021 06:28:56 GMT
This is an automated email from the ASF dual-hosted git repository.

ifplusor pushed a commit to branch n-api
in repository https://gitbox.apache.org/repos/asf/rocketmq-client-nodejs.git

commit 494ae5d70c5e1e01fb9e8495de4ed463fe3039e7
Author: James Yin <ywhjames@hotmail.com>
AuthorDate: Sun Mar 28 13:29:48 2021 +0800

    fix: compile on linux and ci
---
 deps/rocketmq    | 2 +-
 package.json     | 2 +-
 src/producer.cpp | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/deps/rocketmq b/deps/rocketmq
index fcecc8d..1584a34 160000
--- a/deps/rocketmq
+++ b/deps/rocketmq
@@ -1 +1 @@
-Subproject commit fcecc8dba97972d4c934b00cadc97a07406b563d
+Subproject commit 1584a34ec7a44137085dbc5eb2b3047726b433fc
diff --git a/package.json b/package.json
index 5e38e40..f2ed65e 100644
--- a/package.json
+++ b/package.json
@@ -8,7 +8,7 @@
   "main": "index.js",
   "scripts": {
     "preinstall": "git submodule update --init --recommend-shallow",
-    "install": "deps/rocketmq/build.sh && node-gyp rebuild",
+    "install": "if [ ! -d deps/rocketmq/bin ]; then deps/rocketmq/build.sh; fi &&
node-gyp rebuild",
     "test": "npm run lint && echo 'temp example test' && node example/producer.js
&& node example/push_consumer.js",
     "lint": "eslint ."
   },
diff --git a/src/producer.cpp b/src/producer.cpp
index 45dfe1f..dbab66a 100644
--- a/src/producer.cpp
+++ b/src/producer.cpp
@@ -248,7 +248,7 @@ class ProducerSendCallback : public rocketmq::AutoDeleteSendCallback {
  private:
   using Callback = Napi::TypedThreadSafeFunction<std::nullptr_t,
                                                  ResultOrException,
-                                                 &ProducerSendCallback::CallJs>;
+                                                 ProducerSendCallback::CallJs>;
 
   Callback callback_;
 };

Mime
View raw message