rocketmq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From duhengfore...@apache.org
Subject [rocketmq-flink] branch main updated: ISSUE-4:fix SimpleKeyValueDeserializationSchema and SimpleKeyValueDeserializationSchema class field Accessibility. (#5)
Date Wed, 22 Sep 2021 08:36:19 GMT
This is an automated email from the ASF dual-hosted git repository.

duhengforever pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/rocketmq-flink.git


The following commit(s) were added to refs/heads/main by this push:
     new 5240969  ISSUE-4:fix SimpleKeyValueDeserializationSchema and SimpleKeyValueDeserializationSchema
class field Accessibility. (#5)
5240969 is described below

commit 52409694fadeddd2feed92dab6c83f4a5431bef0
Author: gongzhongqiang <764629910@qq.com>
AuthorDate: Wed Sep 22 16:36:14 2021 +0800

    ISSUE-4:fix SimpleKeyValueDeserializationSchema and SimpleKeyValueDeserializationSchema
class field Accessibility. (#5)
    
    Co-authored-by: gongzhongqiang <gongzhongqiang@oristand.com>
---
 .../common/serialization/SimpleKeyValueDeserializationSchema.java     | 4 ++--
 .../common/serialization/SimpleKeyValueSerializationSchema.java       | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/rocketmq/flink/legacy/common/serialization/SimpleKeyValueDeserializationSchema.java
b/src/main/java/org/apache/rocketmq/flink/legacy/common/serialization/SimpleKeyValueDeserializationSchema.java
index 456f477..3c9ae95 100644
--- a/src/main/java/org/apache/rocketmq/flink/legacy/common/serialization/SimpleKeyValueDeserializationSchema.java
+++ b/src/main/java/org/apache/rocketmq/flink/legacy/common/serialization/SimpleKeyValueDeserializationSchema.java
@@ -26,8 +26,8 @@ public class SimpleKeyValueDeserializationSchema implements KeyValueDeserializat
     public static final String DEFAULT_KEY_FIELD = "key";
     public static final String DEFAULT_VALUE_FIELD = "value";
 
-    public String keyField;
-    public String valueField;
+    private final String keyField;
+    private final String valueField;
 
     public SimpleKeyValueDeserializationSchema() {
         this(DEFAULT_KEY_FIELD, DEFAULT_VALUE_FIELD);
diff --git a/src/main/java/org/apache/rocketmq/flink/legacy/common/serialization/SimpleKeyValueSerializationSchema.java
b/src/main/java/org/apache/rocketmq/flink/legacy/common/serialization/SimpleKeyValueSerializationSchema.java
index c3ae600..de01cbc 100644
--- a/src/main/java/org/apache/rocketmq/flink/legacy/common/serialization/SimpleKeyValueSerializationSchema.java
+++ b/src/main/java/org/apache/rocketmq/flink/legacy/common/serialization/SimpleKeyValueSerializationSchema.java
@@ -23,8 +23,8 @@ public class SimpleKeyValueSerializationSchema implements KeyValueSerializationS
     public static final String DEFAULT_KEY_FIELD = "key";
     public static final String DEFAULT_VALUE_FIELD = "value";
 
-    public String keyField;
-    public String valueField;
+    private final String keyField;
+    private final String valueField;
 
     public SimpleKeyValueSerializationSchema() {
         this(DEFAULT_KEY_FIELD, DEFAULT_VALUE_FIELD);

Mime
View raw message