samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suneel Marthi (JIRA)" <>
Subject [jira] [Commented] (SAMOA-13) Create "how to contribute" guide
Date Wed, 04 Feb 2015 21:17:35 GMT


Suneel Marthi commented on SAMOA-13:

Added this comments on the PR, capturing them here again for the record.

Not sure what the Sun conventions are with regards to imports.  We should avoid all import
*, that's something that's strictly adhered to in other projects like Mahout, Flink, Oryx.
 Also a line or 2 about the order of imports would be good. 
Typically its been 


import java.*
import 3rd party library implementations
import project specific classes


Samoa could define its own convention but it should be documented somewhere and adhered to
for all code contributions.

> Create "how to contribute" guide
> --------------------------------
>                 Key: SAMOA-13
>                 URL:
>             Project: SAMOA
>          Issue Type: Bug
>            Reporter: Matthieu Morel
> Given that we'd prefer contributions through github, we should update the
file at the root of the project.

This message was sent by Atlassian JIRA

View raw message