samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From senorcarbone <...@git.apache.org>
Subject [GitHub] incubator-samoa pull request: SAMOA-16: Add an adapter for Apache ...
Date Mon, 18 May 2015 14:01:37 GMT
Github user senorcarbone commented on a diff in the pull request:

    https://github.com/apache/incubator-samoa/pull/11#discussion_r30509422
  
    --- Diff: samoa-flink/src/main/java/com/yahoo/labs/flink/com/yahoo/labs/flink/helpers/Utils.java
---
    @@ -0,0 +1,69 @@
    +package com.yahoo.labs.flink.com.yahoo.labs.flink.helpers;
    +
    +/*
    + * #%L
    + * SAMOA
    + * %%
    + * Copyright (C) 2013 - 2015 Yahoo! Inc.
    + * %%
    + * Licensed under the Apache License, Version 2.0 (the "License");
    + * you may not use this file except in compliance with the License.
    + * You may obtain a copy of the License at
    + * 
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + * 
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + * #L%
    + */
    +
    +
    +import com.yahoo.labs.flink.topology.impl.SamoaType;
    +import com.yahoo.labs.samoa.core.ContentEvent;
    +import org.apache.flink.api.common.functions.FilterFunction;
    +import org.apache.flink.api.common.typeinfo.TypeInformation;
    +import org.apache.flink.api.java.functions.KeySelector;
    +import org.apache.flink.api.java.typeutils.TupleTypeInfo;
    +import org.apache.flink.api.java.typeutils.TypeExtractor;
    +import org.apache.flink.streaming.api.datastream.DataStream;
    +
    +import java.util.List;
    +
    +import static org.apache.flink.api.common.typeinfo.BasicTypeInfo.STRING_TYPE_INFO;
    +
    +public class Utils {
    +
    +	public enum Partitioning {SHUFFLE, ALL, GROUP}
    --- End diff --
    
    You are right, we can. I replaced the usage of these with the default partitioning parameters
of SAMOA several commits before, just forgot to remove their definition. I just removed it
completely 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message