samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nicolas-kourtellis <...@git.apache.org>
Subject [GitHub] incubator-samoa pull request: Patch for SAMOA-58 (Samoa AvroFileSt...
Date Thu, 14 Apr 2016 07:26:45 GMT
Github user nicolas-kourtellis commented on the pull request:

    https://github.com/apache/incubator-samoa/pull/48#issuecomment-209803217
  
    +1
    I didn't run the Avro fix, but the rest of the additions look good. Thanks edi-bice!
    
    Note: What I am not sure is if all these additions should have been committed as a single
patch, or independent ones. The patch covers several different things and if someone wants
to roll out one of them, it may not be easy..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message