samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From edi-bice <...@git.apache.org>
Subject [GitHub] incubator-samoa pull request: Patch for SAMOA-58 (Samoa AvroFileSt...
Date Thu, 14 Apr 2016 13:24:19 GMT
Github user edi-bice commented on the pull request:

    https://github.com/apache/incubator-samoa/pull/48#issuecomment-209939526
  
    I agree with you @nicolas-kourtellis about the patch being multiple seemingly unrelated
things. Typical rookie mistake - took off on my fork making all the changes I needed to get
things working for me. Didn't squash either. Had it not been so long since I last worked on
this, I'd offer to start splitting things. 
    
    @abifet let me know what the windowing version should look like and I can work on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message