samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nicolas-kourtellis <...@git.apache.org>
Subject [GitHub] incubator-samoa issue #64: SAMOA-65 JSON serializer/deserializer dedicated f...
Date Thu, 15 Jun 2017 14:43:44 GMT
Github user nicolas-kourtellis commented on the issue:

    https://github.com/apache/incubator-samoa/pull/64
  
    Thank you @pwawrzyniak for the contributions!
    Regarding the current code:
    - Can you change the copyright to be current year? (I wonder if we should keep this year
appearing. It needs constant updating every time we have a new release).
    - I added some minor comments on leftovers from the AVRO combined integration. If you
can remove them it would be cleaner.
    - I noticed that there is redundancy / repetition between the three PRs (#59,#64#65).
Is there a way to make them unique to each other? Otherwise I think there will be conflicts
when trying to merge them. @gdfm what do you think?
    
    - After checking the code, I realized that this is dedicated for Kafka.
    A quick question: Can this JSON serializer/deserializer be extended/abstracted to be used
by other interfaces besides Kafka (e.g., even storing/retrieving JSON files from disk)? Do
you think it is feasible or needs a lot of work?
    - Can we do something similar for Avro?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message