samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nicolas-kourtellis <...@git.apache.org>
Subject [GitHub] incubator-samoa issue #61: SAMOA-68: Saving true and predicted labels to fil...
Date Wed, 21 Jun 2017 14:19:59 GMT
Github user nicolas-kourtellis commented on the issue:

    https://github.com/apache/incubator-samoa/pull/61
  
    Thank you @mgrzenda for the contribution! Very nice!
    I tested it with bagging and VHT, covtypeNorm and random-tree-generator.
    Quick feedback:
    - Can you please remove the copyright years etc., as per the other PRs?
    - Can you add some comments/help on what each of the new parameters mean?
    - I think the new parameter on the frequency is not included in the defined templates.
Can you check and add it?
    - I think the printout of the last prediction is not printed in file. Not such a big deal
but please check if there is something you can do to fix it (or if it's something bigger).
    - Interestingly, the higher the frequency of predicted labels printed (controlled by -h),
the higher the overhead on the execution, and the longer it takes to finish the examples I
tried. However, practically when outputing every say 10 instances, the impact is minimal.
Any way we can make it impact less the execution time? Or is this due to I/O bottleneck to
disk?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message