samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gdfm <...@git.apache.org>
Subject [GitHub] incubator-samoa pull request #61: SAMOA-68: Saving true and predicted labels...
Date Thu, 22 Jun 2017 14:39:01 GMT
Github user gdfm commented on a diff in the pull request:

    https://github.com/apache/incubator-samoa/pull/61#discussion_r123521489
  
    --- Diff: samoa-api/src/main/java/org/apache/samoa/evaluation/BasicClassificationPerformanceEvaluator.java
---
    @@ -111,6 +125,38 @@ public void addResult(Instance inst, double[] classVotes) {
     
       }
     
    +  /**
    +   * This method is used to retrieve predictions and votes (for classification only)
    +   * 
    +   * @return String This returns an array of predictions and votes objects.
    +   */
    +  @Override
    +  public Vote[] getPredictionVotes() {
    --- End diff --
    
    This seems a lot of object creation.
    Could we reuse some of these objects?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message