samoa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gdfm <...@git.apache.org>
Subject [GitHub] incubator-samoa pull request #61: SAMOA-68: Saving true and predicted labels...
Date Thu, 22 Jun 2017 14:39:02 GMT
Github user gdfm commented on a diff in the pull request:

    https://github.com/apache/incubator-samoa/pull/61#discussion_r123524790
  
    --- Diff: samoa-api/src/main/java/org/apache/samoa/evaluation/EvaluatorProcessor.java
---
    @@ -179,6 +211,28 @@ private void addMeasurement() {
         }
       }
     
    +  /**
    +   * This method is used to create one line of a text file containing predictions and
votes (for classification only).
    +   * In case, this is the first line a header line is also added
    +   */
    +  private void addVote() {
    +    List<Vote> votes = new Vector<>();
    +    Collections.addAll(votes, evaluator.getPredictionVotes());
    +    Vote[] finalVotes = votes.toArray(new Vote[votes.size()]);
    --- End diff --
    
    I think there is no need to build an array to hold the votes, you can pass the collection
right through.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message