samza-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Garry Turkington" <garry.turking...@gmail.com>
Subject Re: Review Request 15760: SAMZA-77
Date Thu, 21 Nov 2013 12:34:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15760/
-----------------------------------------------------------

(Updated Nov. 21, 2013, 12:34 p.m.)


Review request for samza.


Repository: samza


Description
-------

Added %s tokens to a number of places in KafkaConfig where a random UUID should be added to
an id string.


Diffs
-----

  samza-kafka/src/main/scala/org/apache/samza/config/KafkaConfig.scala 4947b87e1a51654a661ddf3ab606478f0967067d

  samza-kafka/src/test/scala/org/apache/samza/config/TestKafkaConfig.scala PRE-CREATION 

Diff: https://reviews.apache.org/r/15760/diff/


Testing (updated)
-------


Added TestKafkaConfig.scala:
*Create 2 ConsumerConfig objects with no clientId or groupId  arguments passed to constructor.
 Confirmed that the generated client and group ids are indeed different due to the included
UUID.
* Create a ConsumerConfig object with explicit values for clientId and GroupId passed to constructor.
Confirmed the created object has the specified client and group ids.
* Do similar validation with ProducerConfig objects

One question re the test -- is any cleanup needed since the creation of the various config
objects does seem to be spawning up some ZK/Kafka goodness in the background?  I saw occasional
test filaings in TestTopicMetadataCache and it wasn't clear if that was an artefact of my
own tests failing or if something else was going on.


Thanks,

Garry Turkington


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message