spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Wendell <pwend...@gmail.com>
Subject Re: -1s on pull requests?
Date Mon, 04 Aug 2014 03:29:13 GMT
>
>    1. Include the commit hash in the "tests have started/completed"
>    messages, so that it's clear what code exactly is/has been tested for
> each
>    test cycle.
>

Great idea - I think this is easy to do given the current architecture. We
already have access to the commit ID in the same script that posts the
comments.

   2. "Pin" a message to the start or end of the PR that is updated with
>    the status of the PR. "Testing not complete"; "New commits since last
>    test"; "Tests failed"; etc. It should be easy for committers to get the
>    status of the PR at a glance, without scrolling through the comment
> history.
>

This also is a good idea - I think this would be doable since the github
API allows us to edit comments, but it's a bit tricker. I think it would
require first making an API call to get the "status comment" ID and then
updating it.


>
> Nick
>

Nick - Any interest in doing these? this is all doable from within the
spark repo itself because our QA harness scripts are in there:

https://github.com/apache/spark/blob/master/dev/run-tests-jenkins

If not, could you make a JIRA for them and put it under "Project Infra".

- Patrick

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message