+1Sounds like a great idea.--On Sun, Jul 19, 2015 at 10:54 PM, Sandy Ryza <firstname.lastname@example.org> wrote:+1On Sat, Jul 18, 2015 at 4:00 PM, Mridul Muralidharan <email@example.com> wrote:Thanks for detailing, definitely sounds better.+1RegardsMridul
On Saturday, July 18, 2015, Reynold Xin <firstname.lastname@example.org> wrote:A single commit message consisting of:1. Pull request title (which includes JIRA number and component, e.g. [SPARK-1234][MLlib])2. Pull request description3. List of authors contributing to the patchThe main thing that changes is 3: we used to also include the individual commits to the pull request branch that are squashed.On Sat, Jul 18, 2015 at 3:45 PM, Mridul Muralidharan <email@example.com> wrote:Just to clarify, the proposal is to have a single commit msg giving the jira and pr id?That sounds like a good change to have.RegardsMridul
On Saturday, July 18, 2015, Reynold Xin <firstname.lastname@example.org> wrote:I took a look at the commit messages in git log -- it looks like the individual commit messages are not that useful to include, but do make the commit messages more verbose. They are usually just a bunch of extremely concise descriptions of "bug fixes", "merges", etc:cb3f12d [xxx] add whitespace6d874a6 [xxx] support pyspark for yarn-client89b01f5 [yyy] Update the unit test to add more cases275d252 [yyy] Address the comments7cc146d [yyy] Address the comments2624723 [yyy] Fix rebase conflict45befaa [yyy] Update the unit testbbc1c9c [yyy] Fix checkpointing doesn't retain driver port issueAnybody against removing those from the merge script so the log looks cleaner? If nobody feels strongly about this, we can just create a JIRA to remove them, and only keep the author names.