spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacek Laskowski <ja...@japila.pl>
Subject Found a typo in Catalyst's exception and want to write a test -- help needed
Date Thu, 18 Aug 2016 06:46:42 GMT
Hi devs,

While reviewing the code in Catalyst for doing query parsing I found
that UnresolvedStar has this typo in the exception [1].

I do understand that it's a very trivial issue but I thought I'd write
a test for it as part of the change so I could improve my
understanding of the low-level bits and bytes of Catalyst.

scala> ds.select("hello.*")
org.apache.spark.sql.AnalysisException: cannot resolve 'hello.*' give
input columns '';
  at org.apache.spark.sql.catalyst.analysis.UnresolvedStar.expand(unresolved.scala:249)

What test in Spark is the closest proximity to the class that I could
extend to assert the exception's message? How to run the test? Is sbt
catalyst/testOnly [testName] enough?

Please guide. Thanks.

[1] https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala#L249

Pozdrawiam,
Jacek Laskowski
----
https://medium.com/@jaceklaskowski/
Mastering Apache Spark 2.0 http://bit.ly/mastering-apache-spark
Follow me at https://twitter.com/jaceklaskowski

---------------------------------------------------------------------
To unsubscribe e-mail: dev-unsubscribe@spark.apache.org


Mime
View raw message