spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Holden Karau <hol...@pigscanfly.ca>
Subject Re: Committing while Jenkins down?
Date Thu, 10 Oct 2019 16:16:19 GMT
On Thu, Oct 10, 2019 at 9:13 AM Xiao Li <gatorsmile@gmail.com> wrote:

> Thanks! Shane!
>
> AFAIK, it normally takes *more than 5/6 hours* to run all the tests. Any
> major changes in Core/SQL require running all the tests. If any committer
> did it before merging the code, I think it is fine to merge it.
>
Glad were on the same page. Personally I have a desktop I can kick off the
tests on while I keep working on other things. Just need a separate check
out.

Note: Some of the k8s integration tests don’t work outside of Jenkins
without extra configuration, so I think we need to be careful with k8s
related changes.

>
> Xiao
>
> Holden Karau <holden@pigscanfly.ca> 于2019年10月10日周四 上午9:11写道:
>
>> Awesome, thanks Shane :)
>>
>> In the meantime I think committers can just run tests locally and it’ll
>> be a slower process but I don’t think we need to halt all merging.
>>
>> On Thu, Oct 10, 2019 at 9:07 AM Shane Knapp <sknapp@berkeley.edu> wrote:
>>
>>> if we do get power back before the weekend, i can have my sysadmin
>>> head down to the colo friday afternoon and power up jenkins.  he knows
>>> the drill.
>>>
>>>
>>> On Thu, Oct 10, 2019 at 8:50 AM Holden Karau <holden@pigscanfly.ca>
>>> wrote:
>>> >
>>> > I think a reasonable, albeit slow, option is to run the tests locally.
>>> Since the outage could be as long as five days I’d rather not just have PRs
>>> pile up for that entire period.
>>> >
>>> > On Thu, Oct 10, 2019 at 8:38 AM Xiao Li <gatorsmile@gmail.com> wrote:
>>> >>
>>> >> I think we are unable to merge any major PR if we do not know whether
>>> the tests can pass.
>>> >>
>>> >> Xiao
>>> >>
>>> >> Xiao Li <gatorsmile@gmail.com> 于2019年10月10日周四 上午8:36写道:
>>> >>>
>>> >>> Please check the note from Shane.
>>> >>>
>>> >>> [build system] IMPORTANT! northern california fire danger, potential
>>> power outage(s)
>>> >>>
>>> >>> Thomas graves <tgraves@apache.org> 于2019年10月10日周四
上午8:35写道:
>>> >>>>
>>> >>>> This is directed towards committers/PMC members.
>>> >>>>
>>> >>>> It looks like Jenkins will be down for a while, what is everyone's
>>> >>>> thoughts on committing PRs while its down?  Do we want to wait
for
>>> >>>> Jenkins to come back up, manually run things ourselves and commit?
>>> >>>>
>>> >>>> Tom
>>> >>>>
>>> >>>>
>>> ---------------------------------------------------------------------
>>> >>>> To unsubscribe e-mail: dev-unsubscribe@spark.apache.org
>>> >>>>
>>> > --
>>> > Twitter: https://twitter.com/holdenkarau
>>> > Books (Learning Spark, High Performance Spark, etc.):
>>> https://amzn.to/2MaRAG9
>>> > YouTube Live Streams: https://www.youtube.com/user/holdenkarau
>>>
>>>
>>>
>>> --
>>> Shane Knapp
>>> UC Berkeley EECS Research / RISELab Staff Technical Lead
>>> https://rise.cs.berkeley.edu
>>>
>> --
>> Twitter: https://twitter.com/holdenkarau
>> Books (Learning Spark, High Performance Spark, etc.):
>> https://amzn.to/2MaRAG9  <https://amzn.to/2MaRAG9>
>> YouTube Live Streams: https://www.youtube.com/user/holdenkarau
>>
> --
Twitter: https://twitter.com/holdenkarau
Books (Learning Spark, High Performance Spark, etc.):
https://amzn.to/2MaRAG9  <https://amzn.to/2MaRAG9>
YouTube Live Streams: https://www.youtube.com/user/holdenkarau

Mime
View raw message