spark-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hyukjin Kwon <gurwls...@gmail.com>
Subject Auto-closing PRs when there are no feedback or response from its author
Date Wed, 09 Oct 2019 01:19:03 GMT
Hi all,

I think we talked about this before. Roughly speaking, there are two cases
of PRs:
  1. PRs waiting for review and 2. PRs waiting for author's reaction
We might not have to take an action but wait for reviewing for the first
case.
However, we can ping and/or take an action for the second case.

I noticed (at Read the Docs,
https://github.com/readthedocs/readthedocs.org/blob/master/.github/no-response.yml)
there's one bot integrated with Github app that does exactly what we want
(see https://github.com/probot/no-response).

1. Maintainers (committers) can add a tag to a PR (e.g.,
need-more-information)
2. If the PR author responds with a comment or update, the bot removes the
tag
3. If the PR author does not respond, the bot closes the PR after waiting
for the configured number of days.

We already have a kind of simple mechanism for windowing the number of
JIRAs. I think it's time to have such mechanism in Github PR as well.

Although this repo doesn't look popular or widely used enough, seems
exactly matched to what we want and less aggressive since this mechanism
will only work when maintainers (committers) add a tag to a PR.

WDYT guys?

I cc'ed few people who I think were in the past similar discussions.

Mime
View raw message