spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Wendell (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SPARK-1096) Add Scalastyle Plug-in For Spaces after Comments
Date Sun, 30 Mar 2014 04:15:41 GMT

     [ https://issues.apache.org/jira/browse/SPARK-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Patrick Wendell updated SPARK-1096:
-----------------------------------

    Reporter: Patrick Wendell  (was: Patrick Cogan)

> Add Scalastyle Plug-in For Spaces after Comments
> ------------------------------------------------
>
>                 Key: SPARK-1096
>                 URL: https://issues.apache.org/jira/browse/SPARK-1096
>             Project: Apache Spark
>          Issue Type: New Feature
>          Components: Project Infra
>            Reporter: Patrick Wendell
>            Assignee: prashant
>             Fix For: 1.0.0
>
>
> After line length (which is now checked) this is the number one thing people forget in
pull requests. We should see whether a custom scalastyle rule can be used to check this. In
general I'm guessing we'll want to add several custom rules, so this is a good time to look
into how it works. The scala AST seems to have comments as recognized token so it might work,
but not sure if they are gobbled before the plug-in gets to it. This is something to look
into.
> I find this particular style issue so pervasive and annoying that I'd even settle for
a bash command inside of our test script that greps throughout the codebase. Scalastyle is
a much better way to do this though - if we can make it work!



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message