spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Spark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-5399) tree Losses strings should match loss names
Date Mon, 26 Jan 2015 11:51:34 GMT

    [ https://issues.apache.org/jira/browse/SPARK-5399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291741#comment-14291741
] 

Apache Spark commented on SPARK-5399:
-------------------------------------

User 'Lewuathe' has created a pull request for this issue:
https://github.com/apache/spark/pull/4206

> tree Losses strings should match loss names
> -------------------------------------------
>
>                 Key: SPARK-5399
>                 URL: https://issues.apache.org/jira/browse/SPARK-5399
>             Project: Spark
>          Issue Type: Improvement
>          Components: MLlib
>    Affects Versions: 1.2.0, 1.2.1
>            Reporter: Joseph K. Bradley
>            Priority: Minor
>
> tree.loss.Losses.fromString expects certain String names for losses.  These do not match
the names of the loss classes but should.  I believe these strings were the original names
of the losses, and we forgot to correct the strings when we renamed the losses.
> Currently:
> {code}
>     case "leastSquaresError" => SquaredError
>     case "leastAbsoluteError" => AbsoluteError
>     case "logLoss" => LogLoss
> {code}
> Proposed:
> {code}
>     case "SquaredError" => SquaredError
>     case "AbsoluteError" => AbsoluteError
>     case "LogLoss" => LogLoss
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message