spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Owen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-5312) Use sbt to detect new or changed public classes in PRs
Date Tue, 10 Mar 2015 16:57:38 GMT

    [ https://issues.apache.org/jira/browse/SPARK-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355196#comment-14355196
] 

Sean Owen commented on SPARK-5312:
----------------------------------

Oh OK, I resolved given the discussion above, but if you think you have a good shot at proposing
a better solution, reopen it.

> Use sbt to detect new or changed public classes in PRs
> ------------------------------------------------------
>
>                 Key: SPARK-5312
>                 URL: https://issues.apache.org/jira/browse/SPARK-5312
>             Project: Spark
>          Issue Type: Improvement
>          Components: Project Infra
>            Reporter: Nicholas Chammas
>            Priority: Minor
>
> We currently use an [unwieldy grep/sed contraption|https://github.com/apache/spark/blob/19556454881e05a6c2470d406d50f004b88088a2/dev/run-tests-jenkins#L152-L174]
to detect new public classes in PRs.
> Apparently, sbt lets you get a list of public classes [much more directly|http://www.scala-sbt.org/0.13/docs/Howto-Inspect-the-Build.html]
via {{show compile:discoveredMainClasses}}. We should use that instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message