spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Apache Spark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-9518) Clean up GenerateUnsafeRowJoiner
Date Mon, 03 Aug 2015 07:13:04 GMT

    [ https://issues.apache.org/jira/browse/SPARK-9518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651531#comment-14651531
] 

Apache Spark commented on SPARK-9518:
-------------------------------------

User 'davies' has created a pull request for this issue:
https://github.com/apache/spark/pull/7892

> Clean up GenerateUnsafeRowJoiner
> --------------------------------
>
>                 Key: SPARK-9518
>                 URL: https://issues.apache.org/jira/browse/SPARK-9518
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Reynold Xin
>            Assignee: Davies Liu
>
> [~davies]'s suggestion on how to rewrite it to be more clear:
> {code}
> Seq.tabulate(outputBitsetWords) { i => 
>   val bitset = if (i< bitset1Words) {
>     getLong(obj1, i * 8)
>   } else if (i == bitset1Words && bitset1Remainder > 0) {
>     getLong(obj1, i* 8) | getLong(obj2, 0) >>> bitset1Remainder
>   } else {
>     getLong(obj2, i - bitset1Words) <<< bitset1Remainder | getLong(obj2 i -
bitset1Words + 1) >>> bitset1Remainder
>   }
>   putLong(buf, i * 8, bitset)
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message