spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felix Cheung (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-10903) Simplify SQLContext method signatures and use a singleton
Date Wed, 21 Oct 2015 04:43:27 GMT

    [ https://issues.apache.org/jira/browse/SPARK-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966222#comment-14966222
] 

Felix Cheung commented on SPARK-10903:
--------------------------------------

Thanks for testing this out and helping to diagnose the issue.

I'd suggest going with custom dispatch because:

1. Reference objects are all of class 'jobj' - this can cause dispatch problem and would require
additional checks etc.
For instance, the 2nd parameter `data` for createDataFrame can be RDD which is of class 'jobj'
These are the 'jobj' types: Column, DataFrame, GroupData, PipelineModel, RDD/PipelinedRDD,
sqlContext/hiveCtx

2. There are 15 methods we want to remove the sqlContext parameter from.
It is quite messy to add 30 exports just for that.


> Simplify SQLContext method signatures and use a singleton
> ---------------------------------------------------------
>
>                 Key: SPARK-10903
>                 URL: https://issues.apache.org/jira/browse/SPARK-10903
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SparkR
>            Reporter: Narine Kokhlikyan
>            Priority: Minor
>
> Make sqlContext global so that we don't have to always specify it.
> e.g. createDataFrame(iris) instead of createDataFrame(sqlContext, iris)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message