spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Reynold Xin (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SPARK-12761) Clean up duplicated code in scala 2.11 repl.Main
Date Wed, 13 Jan 2016 19:54:39 GMT

     [ https://issues.apache.org/jira/browse/SPARK-12761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Reynold Xin resolved SPARK-12761.
---------------------------------
       Resolution: Fixed
         Assignee: Jakob Odersky
    Fix Version/s: 2.0.0

> Clean up duplicated code in scala 2.11 repl.Main
> ------------------------------------------------
>
>                 Key: SPARK-12761
>                 URL: https://issues.apache.org/jira/browse/SPARK-12761
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Shell
>            Reporter: Jakob Odersky
>            Assignee: Jakob Odersky
>            Priority: Trivial
>             Fix For: 2.0.0
>
>
> There is duplicate code in {{/repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala}}.
According to git blame, I moved the "settings" val to a method-local val, however due to a
subsequent merge it was reintroduced as a global val.
> Cf https://github.com/apache/spark/blame/master/repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala,
line 33.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message