spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miao Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-15363) Example code shouldn't use VectorImplicits._, asML/fromML
Date Thu, 19 May 2016 23:45:13 GMT

    [ https://issues.apache.org/jira/browse/SPARK-15363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292356#comment-15292356
] 

Miao Wang commented on SPARK-15363:
-----------------------------------

[~mengxr] I want to solve this problem by copying MultivariateOnlineSummarizer.scala to mllib-local
using ml.vectors. So in the example, we don't have to import the VectorImplicits._. Do you
think it is the fix that you want?
Thanks!

> Example code shouldn't use VectorImplicits._, asML/fromML
> ---------------------------------------------------------
>
>                 Key: SPARK-15363
>                 URL: https://issues.apache.org/jira/browse/SPARK-15363
>             Project: Spark
>          Issue Type: Improvement
>          Components: Documentation, ML
>            Reporter: Xiangrui Meng
>
> In SPARK-14615, we use VectorImplicits._  and asML in example code to minimize the changes
in that PR. However, this is a private API, which shouldn't appear in the example code. We
should consider update them during QA.
> https://github.com/dbtsai/spark/blob/9d25ebacfb4abf4d80d5f6815fac920d18347799/examples/src/main/scala/org/apache/spark/examples/ml/DataFrameExample.scala



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message