spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dongjoon Hyun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-18419) Fix `JDBCOptions.asConnectionProperties` to be case-insensitive
Date Thu, 01 Dec 2016 19:27:59 GMT

    [ https://issues.apache.org/jira/browse/SPARK-18419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712843#comment-15712843
] 

Dongjoon Hyun commented on SPARK-18419:
---------------------------------------

Sorry, I thought it's resolved.
But, when I tried to verify it, I found it's not.
So, I reopen and refresh the testcase and PR.

> Fix `JDBCOptions.asConnectionProperties` to be case-insensitive
> ---------------------------------------------------------------
>
>                 Key: SPARK-18419
>                 URL: https://issues.apache.org/jira/browse/SPARK-18419
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>            Reporter: Dongjoon Hyun
>            Priority: Minor
>
> This issue aims to fix `JDBCOptions.asConnectionProperties` to be case-insensitive.
> `JDBCOptions.asConnectionProperties` is designed to filter JDBC options out, but it fails
to handle `CaseInsensitiveMap` correctly. For the following example, it returns `Map('numpartitions'
-> "10")` as a wrong result and the assertion fails.
> {code}
> val options = new JDBCOptions(new CaseInsensitiveMap(Map(
>     "url" -> "jdbc:mysql://localhost:3306/temp",
>     "dbtable" -> "t1",
>     "numPartitions" -> "10")))
> assert(options.asConnectionProperties.isEmpty)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message