spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kazuaki Ishizaki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SPARK-21271) UnsafeRow.hashCode assertion when sizeInBytes not multiple of 8
Date Sat, 01 Jul 2017 02:57:00 GMT

    [ https://issues.apache.org/jira/browse/SPARK-21271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070966#comment-16070966
] 

Kazuaki Ishizaki commented on SPARK-21271:
------------------------------------------

I see. This issue comes from the violation such as [a code|https://github.com/apache/spark/blob/master/sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/FixedLengthRowBasedKeyValueBatch.java#L65]
(e.g. length + 4). Should we detect all of these code pieces by inserting an {{assert(length
% 8 == 0)}} at {{pointTo()}}?

> UnsafeRow.hashCode assertion when sizeInBytes not multiple of 8
> ---------------------------------------------------------------
>
>                 Key: SPARK-21271
>                 URL: https://issues.apache.org/jira/browse/SPARK-21271
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 2.2.0
>            Reporter: Bogdan Raducanu
>
> The method is:
> {code}
> public int hashCode() {
>     return Murmur3_x86_32.hashUnsafeWords(baseObject, baseOffset, sizeInBytes, 42);
>   }
> {code}
> but sizeInBytes is not always a multiple of 8 (in which case hashUnsafeWords throws assertion)
- for example here: {code}FixedLengthRowBasedKeyValueBatch.appendRow{code}
> The fix could be to use hashUnsafeBytes or to use hashUnsafeWords but on a prefix that
is multiple of 8.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message