spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao Li (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SPARK-22961) Constant columns no longer picked as constraints in 2.3
Date Wed, 31 Jan 2018 07:51:00 GMT

     [ https://issues.apache.org/jira/browse/SPARK-22961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Xiao Li updated SPARK-22961:
----------------------------
    Issue Type: Bug  (was: Improvement)

> Constant columns no longer picked as constraints in 2.3
> -------------------------------------------------------
>
>                 Key: SPARK-22961
>                 URL: https://issues.apache.org/jira/browse/SPARK-22961
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 2.3.0
>            Reporter: Adrian Ionescu
>            Assignee: Adrian Ionescu
>            Priority: Major
>              Labels: constraints, optimizer, regression
>             Fix For: 2.3.0
>
>
> We're no longer picking up {{x = 2}} as a constraint from something like {{df.withColumn("x",
lit(2))}}
> The unit test below succeeds in {{branch-2.2}}:
> {code}
> test("constraints should be inferred from aliased literals") {
>     val originalLeft = testRelation.subquery('left).as("left")
>     val optimizedLeft = testRelation.subquery('left).where(IsNotNull('a) && 'a
<=> 2).as("left")
>     val right = Project(Seq(Literal(2).as("two")), testRelation.subquery('right)).as("right")
>     val condition = Some("left.a".attr === "right.two".attr)
>     val original = originalLeft.join(right, Inner, condition)
>     val correct = optimizedLeft.join(right, Inner, condition)
>     comparePlans(Optimize.execute(original.analyze), correct.analyze)
>   }
> {code}
> but fails in {{branch-2.3}} with:
> {code}
> == FAIL: Plans do not match ===
>  'Join Inner, (two#0 = a#0)                     'Join Inner, (two#0 = a#0)
> !:- Filter isnotnull(a#0)                       :- Filter ((2 <=> a#0) &&
isnotnull(a#0))
>  :  +- LocalRelation <empty>, [a#0, b#0, c#0]   :  +- LocalRelation <empty>,
[a#0, b#0, c#0]
>  +- Project [2 AS two#0]                        +- Project [2 AS two#0]
>     +- LocalRelation <empty>, [a#0, b#0, c#0]      +- LocalRelation <empty>,
[a#0, b#0, c#0] 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message