spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcelo Vanzin (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SPARK-25766) AMCredentialRenewer can leak FS clients
Date Wed, 13 Feb 2019 21:53:00 GMT

     [ https://issues.apache.org/jira/browse/SPARK-25766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Marcelo Vanzin resolved SPARK-25766.
------------------------------------
    Resolution: Not A Problem

I took a look at the new code (and some of the {{FileSystem}} code in Hadoop), and it seems
we're fine. The old code would disable the fs instance cache, but the new one does not; so
it re-uses the file system instances the app uses, and just invokes methods under a different
UGI instance (which seems to work, so yay?).

> AMCredentialRenewer can leak FS clients
> ---------------------------------------
>
>                 Key: SPARK-25766
>                 URL: https://issues.apache.org/jira/browse/SPARK-25766
>             Project: Spark
>          Issue Type: Bug
>          Components: YARN
>    Affects Versions: 2.4.0
>            Reporter: Steve Loughran
>            Priority: Trivial
>
> AMCredentialRenewer's scheduled {{writeNewCredentialsToHDFS}} operation creates a new
FS connector each time, so as to access the store with refreshed credentials
> but it doesn't close it after, so any resources used by the client are kept around. This
is more expensive with the cloud store connectors which create thread pools. 
> It should call {{remoteFs.close()}} at the end of its work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message