spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Herman van Hovell (Jira)" <j...@apache.org>
Subject [jira] [Resolved] (SPARK-28836) Remove the canonicalize(attributes) method from PlanExpression
Date Fri, 23 Aug 2019 11:29:00 GMT

     [ https://issues.apache.org/jira/browse/SPARK-28836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Herman van Hovell resolved SPARK-28836.
---------------------------------------
    Fix Version/s: 3.0.0
         Assignee: Ali Afroozeh
       Resolution: Fixed

> Remove the canonicalize(attributes) method from PlanExpression
> --------------------------------------------------------------
>
>                 Key: SPARK-28836
>                 URL: https://issues.apache.org/jira/browse/SPARK-28836
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 3.0.0
>            Reporter: Ali Afroozeh
>            Assignee: Ali Afroozeh
>            Priority: Minor
>             Fix For: 3.0.0
>
>
> The canonicalize(attrs: AttributeSeq) method in PlanExpression is somewhat confusing.

>  First, it is not clear why `PlanExpression` should have this method, and why the canonicalization
is not handled
>  by the canonicalized method of its parent, the Expression class. Second, the QueryPlan.normalizeExpressionId
>  is the only place where PlanExpression.canonicalized is being called.
> This PR removes the canonicalize method from the PlanExpression class and delegates the
normalization of expression ids to
>  the QueryPlan.normalizedExpressionId method. Also, the name normalizedExpressions is
more suitable for this method,
>  therefore, the method has also been renamed.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message