spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Gekk (Jira)" <j...@apache.org>
Subject [jira] [Created] (SPARK-30309) Mark `Filter` as a `sealed` class
Date Thu, 19 Dec 2019 17:58:00 GMT
Maxim Gekk created SPARK-30309:
----------------------------------

             Summary: Mark `Filter` as a `sealed` class
                 Key: SPARK-30309
                 URL: https://issues.apache.org/jira/browse/SPARK-30309
             Project: Spark
          Issue Type: Improvement
          Components: SQL
    Affects Versions: 3.0.0
            Reporter: Maxim Gekk


Add the `sealed` keyword to the `Filter` class at the `org.apache.spark.sql.sources` package.
So, the compiler should output a warning if handling of a filter is missed in a datasource:
{code}
Warning:(154, 65) match may not be exhaustive.
It would fail on the following inputs: AlwaysFalse(), AlwaysTrue()
    def translate(filter: sources.Filter): Option[Expression] = filter match {
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message