spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dongjoon Hyun (Jira)" <>
Subject [jira] [Updated] (SPARK-31003) Fix incorrect use of assume() in tests
Date Mon, 02 Mar 2020 23:24:00 GMT


Dongjoon Hyun updated SPARK-31003:
    Issue Type: Bug  (was: Improvement)

> Fix incorrect use of assume() in tests
> --------------------------------------
>                 Key: SPARK-31003
>                 URL:
>             Project: Spark
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 3.0.0
>            Reporter: Josh Rosen
>            Assignee: Josh Rosen
>            Priority: Major
> [~ahirreddy] and I found some cases where {{assume}} and {{assert}} were mixed up in
test suites.
> If an {{assume}} call fails then it will cause the test to be marked as skipped instead
of failed: this is often used to skip tests if certain prerequisites are missing (e.g. to
disable certain tests on Windows). If {{assume}} is mistakenly used in place of {{assert}}
then this can cause logically-failing tests to be skipped, masking bugs.
> This patch fixes several such cases, replacing certain {{assume}} calls with {{assert}}. 

This message was sent by Atlassian Jira

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message