spark-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dongjoon Hyun (Jira)" <j...@apache.org>
Subject [jira] [Resolved] (SPARK-31003) Fix incorrect use of assume() in tests
Date Mon, 02 Mar 2020 23:25:00 GMT

     [ https://issues.apache.org/jira/browse/SPARK-31003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dongjoon Hyun resolved SPARK-31003.
-----------------------------------
    Fix Version/s: 2.4.6
                   3.0.0
       Resolution: Fixed

This is resolved via https://github.com/apache/spark/pull/27754

> Fix incorrect use of assume() in tests
> --------------------------------------
>
>                 Key: SPARK-31003
>                 URL: https://issues.apache.org/jira/browse/SPARK-31003
>             Project: Spark
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 3.0.0
>            Reporter: Josh Rosen
>            Assignee: Josh Rosen
>            Priority: Major
>             Fix For: 3.0.0, 2.4.6
>
>
> [~ahirreddy] and I found some cases where {{assume}} and {{assert}} were mixed up in
test suites.
> If an {{assume}} call fails then it will cause the test to be marked as skipped instead
of failed: this is often used to skip tests if certain prerequisites are missing (e.g. to
disable certain tests on Windows). If {{assume}} is mistakenly used in place of {{assert}}
then this can cause logically-failing tests to be skipped, masking bugs.
> This patch fixes several such cases, replacing certain {{assume}} calls with {{assert}}. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org


Mime
View raw message