spark-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sun, Rui" <rui....@intel.com>
Subject RE: lint-r checks failing
Date Fri, 11 Mar 2016 06:32:42 GMT
This is probably because the installed lintr package get updated. After update, lintr can detect
errors that are skipped before

I will submit a PR for this issue

-----Original Message-----
From: Gayathri Murali [mailto:gayathri.m.softie@gmail.com] 
Sent: Friday, March 11, 2016 12:48 PM
To: user@spark.apache.org
Subject: lint-r checks failing

Hi All,

I recently tried to run ./dev/run-tests on a freshly clones spark repository and I get lint-r
check failed error. I have run these tests multiple times before and never had this issue.
I have copied part of the issue here. Please note that I haven’t modified any of these files.
Am I missing some setup for lint-r?

/sparkR.R:156:25: style: Put spaces around all infix operators.
    f <- file(path, open="rb")
                       ~^~
R/sparkR.R:188:5: style: Place a space before left parenthesis, except in a function call.
  if(is.null(sparkExecutorEnvMap$LD_LIBRARY_PATH)) {
    ^
R/sparkR.R:190:34: style: Commas should always have a space after.
      paste0("$LD_LIBRARY_PATH:",Sys.getenv("LD_LIBRARY_PATH"))
                                 ^
R/utils.R:161:32: style: Commas should always have a space after.
  vec <- c(bitwShiftL(val, c(4,3,2,1,0)), addVal)
                               ^
R/utils.R:161:34: style: Commas should always have a space after.
  vec <- c(bitwShiftL(val, c(4,3,2,1,0)), addVal)
                                 ^
R/utils.R:161:36: style: Commas should always have a space after.
  vec <- c(bitwShiftL(val, c(4,3,2,1,0)), addVal)
                                   ^
R/utils.R:161:38: style: Commas should always have a space after.
  vec <- c(bitwShiftL(val, c(4,3,2,1,0)), addVal)
                                     ^
R/utils.R:205:5: style: Place a space before left parenthesis, except in a function call.
  if(acc$counter == acc$size) {
    ^
lintr checks failed.
[error] running /Users/gayathri/spark/dev/lint-r ; received return code 1

Thanks
Gayathri



---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@spark.apache.org For additional commands, e-mail:
user-help@spark.apache.org

Mime
View raw message