spot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nathanael Smith <nathan...@apache.org>
Subject [SPOT-23] PR #24 | review PR and proposal for additional changes
Date Tue, 11 Apr 2017 18:18:06 GMT
Hello,

Please review and test this PR,
https://github.com/apache/incubator-spot/pull/24/ <https://github.com/apache/incubator-spot/pull/24/>

TLDR; I’d love community feedback and participation in how spot is installed, maintained
and run. Proposing several long term changes to make this feel more like a complete solution.

There are some significant changes here,

* SPOT-SETUP/install.sh creates /opt/spot/{bin,jar}, creates /etc/profile.d/spot.sh which
updates the $PATH
* SPOT-INGEST/install.sh installs all dependencies, including tshark, nfdump to /opt/spot/bin/
* SPOT-ML/install.sh installs sbt, builds the jar and copies it to /opt/spot/jar, copies ml_ops.sh
to /opt/spot/bin
* SPOT-OA/install.sh installs npm, builds the ui

I have not moved the scripts for ingest or OA into the bin yet but want to add this later,
perhaps these should be changed to more notable names to create a suite of tools that can
be called from anywhere.
Meaning something like start_ingest_standalone.sh <https://github.com/apache/incubator-spot/blob/master/spot-ingest/start_ingest_standalone.sh>
could be changed to `spot-ingest` and be included in /opt/spot/bin.

a more complete list of changes:

start_ingest_standalone.sh —> spot-ingest
ml_ops.sh —> spot-ml
runIpython.sh —> spot-ui (see my notes below for additional requirements for spot-ui)
start_oa.py —> spot-oa

for spot-ui i would suggest a start/kill option for the script.
`spot-ui start` would run ipython while `spot-ui kill` would actually stop the process.
This would require a little bit of thought and bash magic, as i’d suggest that grepping
for the process and running kill might not be the right option.
 
- Nathanael




Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message