sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "richard zhou" <yixinxiangs...@gmail.com>
Subject Re: Review Request 26678: SQOOP-1526: Kerberos support when starting service
Date Mon, 27 Oct 2014 08:39:23 GMT


> On Oct. 22, 2014, 7:19 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/authentication/AuthenticationHandlerFactory.java,
lines 28-34
> > <https://reviews.apache.org/r/26678/diff/5/?file=728669#file728669line28>
> >
> >     If the type is neither of "KERBEROS" nor "SIMPLE" can we try to use it as a
classname and instantiate it?
> >     
> >     I would like to provide user ability to specify their own authentication class
implementation if needed. This one can be probably done in follow up JIRA though :)
> 
> richard zhou wrote:
>     Good suggestion, I will create a JIRA for it

As I have refacted the code today, I have made these changes in this diff.


> On Oct. 22, 2014, 7:19 p.m., Jarek Cecho wrote:
> > core/pom.xml, lines 62-66
> > <https://reviews.apache.org/r/26678/diff/5/?file=728665#file728665line62>
> >
> >     Can we move the concrete implementation to it's own module? I would prefer not
to introduce hadoop dependency on core.
> 
> richard zhou wrote:
>     Could the hadoop dependency be compile instead of provided?
>     I do not prefer to write a duplicate code to implement this, only because to avoid
adding hadoop dependency.
>     Could we use reflect (ClassUtils.loadClass)?
>     Or which component in sqoop could add hadoop dependency? excution? submission? could
we move KerberosAuthenticationHandler to this component or create a security component to
add haoop dependency?
> 
> Veena Basavaraj wrote:
>     please no duplicate code. you will run out of sync sometime
>     
>     I like the idea of a security component and move thse things out of core
> 
> Abraham Elmahrek wrote:
>     +1 on security component.
> 
> Jarek Cecho wrote:
>     The way we designed Sqoop 2 is to push all Hadoop dependencies as far as possible,
so that it's very easy to run Sqoop 2 without Hadoop. That is why execution engine sits in
it's own separate module - in the core we have abstraction of execution engine that is implemented
that separate module. I would like to see the same on the kerberos side, so that we have abstraction
in the core, but the concrete implementation that brings huge amount of dependencies in separate
module. This way the "core" module is very light in terms of dependencies and it's about the
concrete components that brings all the dependencies and user can choose what dependencies
they need based on what concrete components that wish to use. I would prefer not to break
this one.

I have moved it to security component.


- richard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26678/#review57867
-----------------------------------------------------------


On Oct. 27, 2014, 8:37 a.m., richard zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26678/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 8:37 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Kerberos support when starting service
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/core/SqoopServer.java ac836c7cee010144696ab17645ccd008aed5762d

>   core/src/main/java/org/apache/sqoop/security/AuthenticationConstants.java PRE-CREATION

>   core/src/main/java/org/apache/sqoop/security/AuthenticationError.java PRE-CREATION

>   core/src/main/java/org/apache/sqoop/security/AuthenticationHandler.java PRE-CREATION

>   core/src/main/java/org/apache/sqoop/security/AuthenticationHandlerFactory.java PRE-CREATION

>   core/src/main/java/org/apache/sqoop/security/AuthenticationManager.java PRE-CREATION

>   dist/src/main/server/conf/sqoop.properties bb010166120321899425f84edb8e1ad6512626d2

>   pom.xml f25a29f6db673e6080dcd5ccd51bab76ab38bff4 
>   security/pom.xml PRE-CREATION 
>   security/src/main/java/org/apache/sqoop/security/KerberosAuthenticationHandler.java
PRE-CREATION 
>   security/src/main/java/org/apache/sqoop/security/SimpleAuthenticationHandler.java PRE-CREATION

>   server/pom.xml 67baaa57da9f69f2e8795107ca1b6186eaef2b9c 
> 
> Diff: https://reviews.apache.org/r/26678/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> richard zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message