sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sqoop QA bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-2451) Sqoop2: Findbugs: Add explicit charset to client ResourceRequest class
Date Thu, 30 Jul 2015 01:14:04 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647018#comment-14647018
] 

Sqoop QA bot commented on SQOOP-2451:
-------------------------------------

Testing file [SQOOP-2451.patch|https://issues.apache.org/jira/secure/attachment/12747889/SQOOP-2451.patch]
against branch sqoop2 took 0:40:43.334926.

{color:red}Overall:{color} -1 due to an error(s), see details below:

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:red}ERROR:{color} Patch does not add/modifny any test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 683 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1495/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 71 tests)

Console output is available [here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1495/console].

This message is automatically generated.

> Sqoop2: Findbugs: Add explicit charset to client ResourceRequest class
> ----------------------------------------------------------------------
>
>                 Key: SQOOP-2451
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2451
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2451.patch
>
>
> I feel that this one is quite valid concern - we're not explicitly specifying what encoding
we're using when serializing/deserializing data. We're depending on the default UTF-8 being
set, which is not optimal as some users can change that and then things will break.
> I'll attach class to fix this in the {{client}} module and will fix other module as I'll
get to them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message