sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-3233) SqoopHCatImportHelper.convertNumberTypes check for Varchar instead of Char
Date Fri, 08 Dec 2017 10:46:00 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283352#comment-16283352
] 

ASF subversion and git services commented on SQOOP-3233:
--------------------------------------------------------

Commit 855c56fef8ab833e63587f17f70030e2c7764f4a in sqoop's branch refs/heads/trunk from [~vasas]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=855c56f ]

SQOOP-3233: SqoopHCatImportHelper.convertNumberTypes check for Varchar instead of Char

(Ferenc Szabo via Szabolcs Vasas)


> SqoopHCatImportHelper.convertNumberTypes check for Varchar instead of Char
> --------------------------------------------------------------------------
>
>                 Key: SQOOP-3233
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3233
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.4.6
>            Reporter: Zoltán Tóth
>            Assignee: Ferenc Szabo
>            Priority: Minor
>         Attachments: SQOOP-3233.patch
>
>
> I found an issue in SqoopHCatImportHelper.convertNumberTypes method. In the if block
it checks for VARCHAR type and in the if else statement it does the same but should be a CHAR
check.
> {code:title=org.apache.sqoop.mapreduce.hcat.SqoopHCatImportHelper.convertNumberTypes}
> if (hfsType == HCatFieldSchema.Type.VARCHAR) {
>         VarcharTypeInfo vti = (VarcharTypeInfo) hfs.getTypeInfo();
>         HiveVarchar hvc = new HiveVarchar(bdStr, vti.getLength());
>         return hvc;
>       } else if (hfsType == HCatFieldSchema.Type.VARCHAR) {
>         CharTypeInfo cti = (CharTypeInfo) hfs.getTypeInfo();
>         HiveChar hChar = new HiveChar(bdStr, cti.getLength());
>         return hChar;
>       } else {
>         return bdStr;
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message