struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <j...@apache.org>
Subject [jira] [Commented] (WW-5088) Empty file upload gives wrong error message
Date Mon, 07 Sep 2020 07:26:00 GMT

    [ https://issues.apache.org/jira/browse/WW-5088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191518#comment-17191518
] 

ASF subversion and git services commented on WW-5088:
-----------------------------------------------------

Commit abb1c4d974ab48358d09bc509c6094b1569028fd in struts's branch refs/heads/master from
Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=abb1c4d ]

Merge pull request #435 from gregh3269/master

[WW-5088] Empty file upload, storeLocation null gives wrong error message.

> Empty file upload gives wrong error message
> -------------------------------------------
>
>                 Key: WW-5088
>                 URL: https://issues.apache.org/jira/browse/WW-5088
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.5.22
>            Reporter: Greg Huber
>            Priority: Minor
>             Fix For: 2.6
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> On an empty file upload the storeLocation is null, so adds a file new StrutsUploadedFile(null)
> JakartaMultiPartRequest
> {code:java}
> List fileList = new ArrayList<>(items.size());
> for (FileItem fileItem : items) {
> File storeLocation = ((DiskFileItem) fileItem).getStoreLocation();
> if (fileItem.isInMemory() && storeLocation != null && !storeLocation.exists())
{
> try {
> storeLocation.createNewFile();
> } catch (IOException e) {
> LOG.error("Cannot write uploaded empty file to disk: {}", storeLocation.getAbsolutePath(),
e);
> }
> }
> fileList.add(new StrutsUploadedFile(storeLocation));
> }
> {code}
> The FileUploadInterceptor checks for a null file but not null content from the new StrutsUploadedFile(null).
> eg for an empty file main.js
> Error message should be:
> Error uploading: main.js
> but gives:
> Error setting expression 'uploadedFiles' with value ['org.apache.struts2.dispatcher.multipart.StrutsUploadedFile@202585bc',
]
> Error setting expression 'uploadedFiles' with value ['org.apache.struts2.dispatcher.multipart.StrutsUploadedFile@49553150',
]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message