tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CharSyam <chars...@gmail.com>
Subject Re: [DISCUSS] patch review process
Date Thu, 02 Jan 2014 07:17:47 GMT
I think it is very good idea.

I hope those kinds of jobs run automatically.

1] run "mvn clean install"
after it successes.
2] adding diff to reviewboard.

2014/1/2 Hyunsik Choi <hyunsik@apache.org>

> Hi folks,
> As the community and the number of contributors grow, more patches are
> being submitted. We have faced the increasing burden of patch peer
> review. So far,  we have mostly submitted patches to Jira and leaved
> comments on the corresponding JIRA issue. This way is not bad, but its
> productivity for review is not good.
> In order to mitigate the burden of patch review, I propose that we
> should use reviewboard for more significant than minor issues.
> Reviewboard allows reviewers to directly add ideas and comments on the
> diff or source code. In addition, Reviewboard enables reviews to view
> the only difference between two patches. I think that they are really
> nice features. I believe we will experience more efficient and
> convenient review process if we use reviewboard more. I also think
> that this rule should be strongly recommended rather than mandatory.
> If you have any idea, feel free to suggest me. Also, I welcome just an
> agreement expression about this idea.
> - hyunsik

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message