tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jaewoong Jung <jun...@gmail.com>
Subject Re: tajoCli history behavior
Date Sat, 08 Nov 2014 06:38:45 GMT
Cool! Issue created: https://issues.apache.org/jira/browse/TAJO-1159

Also assigned the \q issue to myself.

Thanks for your warm welcome. Looking forward to working together to
make tajo a hugely successful project. :)

On Fri, Nov 7, 2014 at 2:04 AM, Hyunsik Choi <hyunsik.choi@gmail.com> wrote:
> Hi Jaewoong,
> First of all, welcome to Tajo community.
> Yes, you are right. The behavior of tsql is somewhat different from
> bash's history.
> As you mentioned, tsql (i.e., TajoCli) recognizes multiple commands in
> one line into multiple individual commands.
> I totally agree with your suggestion. It would be better if tsql
> provides the same user experience to bash.
> As far as I know, bash and mysql use readline. But, Tajo uses
> jline2 (https://github.com/jline/jline2), which is readline clone
> implemented in Java.
> So, you may need to dig into jline2. Since jline2 is well designed and
> provides many interfaces to
> allow users to customize the history behavior, your suggestion seems
> to be possible.
> Please feel free to create a jira issues for it.
> Best regards,
> Hyunsik
> On Thu, Nov 6, 2014 at 11:48 PM, Jaewoong Jung <jungjw@gmail.com> wrote:
>> Hi all,
>> First, a bit of introduction to myself. I'm a software engineer
>> working at Google and was introduced to Tajo project by my friend,
>> Keeyong Han, when I was looking for an open-source project to
>> contribute to. My current role at Google is writing a REST API server
>> in Java and Android client. But I also have a fair amount of
>> experience with MapReduce and FlumeJava, so I'm hoping I can be of
>> help in improving and enhancing the project.
>> As a newbie to the open source world and Hadoop, I decided to pick up
>> the easiest tasks, and this one caught my eye.
>> https://issues.apache.org/jira/browse/TAJO-967
>> I took a quick look at the source code, and it looked like a simple
>> task, indeed.
>> However, I also discovered tajoCli's history behavior was slightly
>> different from others like bash and mysql.
>> When the user enters multiple commands in a single line using
>> semicolon and looks it up using up arrow key later, tajoCli shows each
>> individual command separately, whereas bash and mysql shows all the
>> commands in a single line as they were entered.
>> For example, if the user enters two commands in a single line like this,
>> \version; \d
>> tajoCli shows \d first and then \version as the user presses up arrow
>> key twice. But, bash and mysql show \version; \d together again with a
>> single up action.
>> I don't think bash and mysql's history behavior is necessarily better
>> than tajoCli or vice verssa, but, IMHO, it'd be better if tajo
>> provides user experience that users are used to and naturally expect.
>> WDYT? If you agree, I can make the change myself.
>> Thanks,
>> Jaewoong

View raw message