tez-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bikas Saha <bi...@hortonworks.com>
Subject RE: Expiring Held Containers with Min Held 0
Date Mon, 18 Aug 2014 17:44:25 GMT
Jira and patch welcome!

-----Original Message-----
From: Thaddeus Diamond [mailto:thaddeus.diamond@gmail.com]
Sent: Monday, August 18, 2014 8:17 AM
To: dev@tez.apache.org; user@tez.apache.org
Subject: Expiring Held Containers with Min Held 0

I think there's a bug with the deallocateTask() in YarnTaskSchedulerService.
Lines 991 - 993 read:

            if (idleContainerTimeoutMin > 0) {

heldContainer.setContainerExpiryTime(getHeldContainerExpireTime(currentTime));
            }

I think it should be *>=* because if the min is 0 and max is, say, 10 you
still want to get a random number between 0 and 10.

Thanks,
Thad

-- 
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to 
which it is addressed and may contain information that is confidential, 
privileged and exempt from disclosure under applicable law. If the reader 
of this message is not the intended recipient, you are hereby notified that 
any printing, copying, dissemination, distribution, disclosure or 
forwarding of this communication is strictly prohibited. If you have 
received this communication in error, please contact the sender immediately 
and delete it from your system. Thank You.

Mime
View raw message