tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Junckes Filho (JIRA)" <j...@apache.org>
Subject [jira] [Created] (TOMEE-2284) Metrics Microprofile Example for @Metered
Date Thu, 22 Nov 2018 11:27:00 GMT
Ivan Junckes Filho created TOMEE-2284:
-----------------------------------------

             Summary: Metrics Microprofile Example for @Metered
                 Key: TOMEE-2284
                 URL: https://issues.apache.org/jira/browse/TOMEE-2284
             Project: TomEE
          Issue Type: Task
            Reporter: Ivan Junckes Filho


We would like to have an example for MicroProfile Metrics @Metered annotation.

Here is a quick tutorial on MicroProfile Metrics if you are not aware:

[https://www.tomitribe.com/blog/getting-started-with-microprofile-metrics/]

Fork / clone the TomEE project from here:

[https://github.com/apache/tomee]

Example name should be _mp-metrics-metered_, following the standard already in the project.

All the examples are in:

[https://github.com/apache/tomee/tree/master/examples]

See this example of @Counted for reference:

[https://github.com/apache/tomee/tree/master/examples/mp-metrics-counted]

See these two PRs for the diff for @Counted, it will help you see how simple it is:

[https://github.com/apache/tomee/pull/203]

[https://github.com/apache/tomee/pull/207]

What you have to do is:

1 - Create a method in the WeatherService class with @Metered

2 - Have a WeatherServiceTest for the GET and OPTIONS scenarios of @Metered

3 - Make sure you have tests for Prometheus and JSON formats

4 - Make sure all the tests pass

After that submit a PR and we'll review it.

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message