trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: trafficserver git commit: TS-3479 Remove verbose Warning() from HTTP/2 connections
Date Fri, 03 Apr 2015 15:16:37 GMT

> On Apr 2, 2015, at 8:55 PM, Leif Hedstrom <zwoop@apache.org> wrote:
> 
>> 
>> On Apr 2, 2015, at 9:51 PM, Leif Hedstrom <zwoop@apache.org> wrote:
>> 
>>> 
>>> On Apr 1, 2015, at 6:08 PM, James Peach <jpeach@apache.org> wrote:
>>> 
>>> 
>>>> On Apr 1, 2015, at 3:50 PM, zwoop@apache.org wrote:
>>>> 
>>> [snip]
>>>> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/26f438d4/proxy/http2/Http2SessionAccept.cc
>>>> ----------------------------------------------------------------------
>>>> diff --git a/proxy/http2/Http2SessionAccept.cc b/proxy/http2/Http2SessionAccept.cc
>>>> index 5fe2ce7..fbb25db 100644
>>>> --- a/proxy/http2/Http2SessionAccept.cc
>>>> +++ b/proxy/http2/Http2SessionAccept.cc
>>>> @@ -40,7 +40,7 @@ Http2SessionAccept::accept(NetVConnection *netvc, MIOBuffer
*iobuf, IOBufferRead
>>>> {
>>>> // XXX we need to refactor the ACL checks from HttpSessionAccept so that
we can invoke them here, and also in
>>>> // the SPDY protocol layer ...
>>>> -  Warning("skipping access control checks for HTTP/2 connection");
>>>> +  // Warning("skipping access control checks for HTTP/2 connection");
>>> 
>>> I added this warning so that someone would wire up the access control checks
for HTTP/2. I don't think we should remove the warning without doing that :)
>> 
>> 
>> I disagree, the Warning() makes the entire HTTP2 feature useless since it’ll fill
up the disk :/.

yeh filling up the disk is bad

>> Feel free to make it a single warning on startup maybe ?
> 
> 
> I filed a Jira though, since there was none.

thanks .. and thanks for the other patch ;)

J
Mime
View raw message