trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: trafficserver git commit: TS-3977: Add cache-key-genid to experimental plugins. This closes #309.
Date Thu, 03 Mar 2016 21:49:04 GMT

> On Mar 3, 2016, at 12:16 PM, amc@apache.org wrote:
> 
> Repository: trafficserver
> Updated Branches:
>  refs/heads/master 1d1cb8fae -> fbdf0221d
> 
> 
> TS-3977: Add cache-key-genid to experimental plugins.
> This closes #309.
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/fbdf0221
> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/fbdf0221
> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/fbdf0221
> 
> Branch: refs/heads/master
> Commit: fbdf0221df113029bbfb4b35b650c768c900e515
> Parents: 1d1cb8f
> Author: Steven Feltner <sfeltner@godaddy.com>
> Authored: Thu Oct 22 10:55:05 2015 -0700
> Committer: Alan M. Carroll <amc@apache.org>
> Committed: Thu Mar 3 14:12:56 2016 -0600
> 
> ----------------------------------------------------------------------
> NOTICE                                          |   7 +-
> configure.ac                                    |  14 ++
> plugins/experimental/Makefile.am                |   4 +
> .../experimental/cache_key_genid/Makefile.am    |  22 +++
> .../cache_key_genid/cache_key_genid.c           | 174 +++++++++++++++++++
> 5 files changed, 218 insertions(+), 3 deletions(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/fbdf0221/NOTICE
> ----------------------------------------------------------------------
> diff --git a/NOTICE b/NOTICE
> index 15d94b6..7ee263f 100644
> --- a/NOTICE
> +++ b/NOTICE
> @@ -9,6 +9,7 @@ This product includes software developed at
>   - Comcast
>   - LinkedIn
>   - Mike Pall
> +  - GoDaddy
> 
> ~~~
> 
> @@ -44,8 +45,8 @@ Copyright (C) 2012 Oregon Health & Science University
> 
> ~~~
> 
> -healthcheck Plugin developed by GoDaddy.
> -Copyright (C) 2012 GoDaddy.
> +cache-key-genid Plugin developed by GoDaddy
> +Copyright (C) 2013 GoDaddy Operating Company, LLC
> 
> ~~~
> 
> @@ -84,7 +85,7 @@ Copyright (C) 2016 Yahoo! Inc.  All rights reserved.
> ~~~
> 
> healthchecks: Plugin for ATS healthchecks.
> -Copyright (C) 2012 Go Daddy Operating Company, LLC
> +Copyright (C) 2012 GoDaddy Operating Company, LLC
> 
> ~~~
> 
> 
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/fbdf0221/configure.ac
> ----------------------------------------------------------------------
> diff --git a/configure.ac b/configure.ac
> index 530d8c7..26e446e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1454,6 +1454,19 @@ AC_CHECK_LIB([mysqlclient],[mysql_info],[AC_SUBST([LIB_MYSQLCLIENT],["-lmysqlcli
> AC_SUBST(has_mysql)
> AM_CONDITIONAL([HAS_MYSQL], [ test "x${has_mysql}" = "x1" ])
> 
> +AC_CHECK_HEADERS([kclangc.h], [
> +  AC_CHECK_LIB([kyotocabinet], [kcdbopen], [
> +    AC_SUBST([LIB_KYOTOCABINET], ["-lkyotocabinet"])
> +    has_kyotocabinet=1
> +  ], [
> +    has_kyotocabinet=0

The convention is to use "yes" and "no". Can we please be consistent here?

J
Mime
View raw message