trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackso...@apache.org
Subject [trafficserver] branch master updated: TS-4535 fix segfault in hostdb for serve_stale_for with no hostname (#714)
Date Tue, 14 Jun 2016 19:22:37 GMT
This is an automated email from the ASF dual-hosted git repository.

jacksontj pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
       new  96d5fb5   TS-4535 fix segfault in hostdb for serve_stale_for with no hostname
(#714)
96d5fb5 is described below

commit 96d5fb521d573230e541261167388158ae3a3346
Author: Thomas Jackson <jacksontj.89@gmail.com>
AuthorDate: Tue Jun 14 12:22:30 2016 -0700

    TS-4535 fix segfault in hostdb for serve_stale_for with no hostname (#714)
    
    Not all requests have host_name (such as reverse lookups) -- but we want to serve stale
but revalidate for all of them
    
    this closes #714
---
 iocore/hostdb/HostDB.cc | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/iocore/hostdb/HostDB.cc b/iocore/hostdb/HostDB.cc
index 8bb5485..7e70d16 100644
--- a/iocore/hostdb/HostDB.cc
+++ b/iocore/hostdb/HostDB.cc
@@ -691,13 +691,11 @@ probe(ProxyMutex *mutex, HostDBMD5 const &md5, bool ignore_timeout)
       if ((!ignore_timeout && r->is_ip_stale() && !cluster_machine_at_depth(master_hash(md5.hash))
&& !r->reverse_dns) ||
           (r->is_ip_timeout() && r->serve_stale_but_revalidate())) {
         Debug("hostdb", "stale %u %u %u, using it and refreshing it", r->ip_interval(),
r->ip_timestamp, r->ip_timeout_interval);
-        if (!is_dotted_form_hostname(md5.host_name)) {
-          HostDBContinuation *c = hostDBContAllocator.alloc();
-          HostDBContinuation::Options copt;
-          copt.host_res_style = host_res_style_for(r->ip());
-          c->init(md5, copt);
-          c->do_dns();
-        }
+        HostDBContinuation *c = hostDBContAllocator.alloc();
+        HostDBContinuation::Options copt;
+        copt.host_res_style = host_res_style_for(r->ip());
+        c->init(md5, copt);
+        c->do_dns();
       }
 
       r->hits++;

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <commits@trafficserver.apache.org>'].

Mime
View raw message