trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ok...@apache.org
Subject [trafficserver] branch master updated: Disable the post_transform retry due to coredump
Date Fri, 02 Jun 2017 13:36:31 GMT
This is an automated email from the ASF dual-hosted git repository.

oknet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
       new  8dd4aa9   Disable the post_transform retry due to coredump
8dd4aa9 is described below

commit 8dd4aa930317caa598d7622d3b7e091a4a23f875
Author: scw00 <616955249@qq.com>
AuthorDate: Sun May 28 08:40:27 2017 +0800

    Disable the post_transform retry due to coredump
---
 proxy/http/HttpSM.h        | 8 ++++++++
 proxy/http/HttpTransact.cc | 5 +++++
 2 files changed, 13 insertions(+)

diff --git a/proxy/http/HttpSM.h b/proxy/http/HttpSM.h
index cca6379..3226403 100644
--- a/proxy/http/HttpSM.h
+++ b/proxy/http/HttpSM.h
@@ -238,6 +238,14 @@ public:
   VConnection *do_transform_open();
   VConnection *do_post_transform_open();
 
+  // Called by transact(HttpTransact::is_request_retryable), temperarily.
+  // This function should be remove after #1994 fixed.
+  bool
+  is_post_transform_request()
+  {
+    return t_state.method == HTTP_WKSIDX_POST && post_transform_info.vc;
+  }
+
   // Called from InkAPI.cc which acquires the state machine lock
   //  before calling
   int state_api_callback(int event, void *data);
diff --git a/proxy/http/HttpTransact.cc b/proxy/http/HttpTransact.cc
index bdeb6d0..395b6f0 100644
--- a/proxy/http/HttpTransact.cc
+++ b/proxy/http/HttpTransact.cc
@@ -6326,6 +6326,11 @@ HttpTransact::is_request_retryable(State *s)
     return false;
   }
 
+  // FIXME: disable the post transform retry currently.
+  if (s->state_machine->is_post_transform_request()) {
+    return false;
+  }
+
   if (s->state_machine->plugin_tunnel_type != HTTP_NO_PLUGIN_TUNNEL) {
     // API can override
     if (s->state_machine->plugin_tunnel_type == HTTP_PLUGIN_AS_SERVER && s->api_info.retry_intercept_failures
== true) {

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <commits@trafficserver.apache.org>'].

Mime
View raw message