trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jpe...@apache.org
Subject [trafficserver] 06/06: Revert "Add logic to flush gcov data from traffic_server on interrupt."
Date Tue, 06 Jun 2017 02:56:02 GMT
This is an automated email from the ASF dual-hosted git repository.

jpeach pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

commit da1ce2c294889aca5b2b615102bb8ca8ec9bc3f4
Author: James Peach <jpeach@apache.org>
AuthorDate: Sun Jun 4 11:50:51 2017 -0700

    Revert "Add logic to flush gcov data from traffic_server on interrupt."
    
    This reverts commit 1f54cf0c41d3bcb09f4759ccbee509d14ec1ded9.
    
    We no longer need to explicitly flush coverage data, because we don't
    _exit(2) from signal handler any more.
---
 configure.ac           | 4 +---
 lib/ts/ink_config.h.in | 1 -
 proxy/Main.cc          | 9 ---------
 3 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/configure.ac b/configure.ac
index 2c5c518..1c21488 100644
--- a/configure.ac
+++ b/configure.ac
@@ -176,15 +176,13 @@ AC_ARG_ENABLE([mime-sanity-check],
 AC_MSG_RESULT([$enable_mime_sanity_check])
 
 # Enable code coverage instrumentation only if requested by the user.
-use_gcov=0
 AC_MSG_CHECKING([whether to code coverage])
 AC_ARG_ENABLE([coverage],
   [AS_HELP_STRING([--enable-coverage],[generate code coverage instrumentation])],
-  [use_gcov=1],
+  [],
   [enable_coverage=no]
 )
 AC_MSG_RESULT([$enable_coverage])
-AC_SUBST(use_gcov)
 
 #
 # Enable -Werror. We want this enabled by default for developers, but disabled by default
diff --git a/lib/ts/ink_config.h.in b/lib/ts/ink_config.h.in
index ec58faa..79b2c00 100644
--- a/lib/ts/ink_config.h.in
+++ b/lib/ts/ink_config.h.in
@@ -58,7 +58,6 @@
 #define TS_HAS_IN6_IS_ADDR_UNSPECIFIED @has_in6_is_addr_unspecified@
 #define TS_HAS_BACKTRACE @has_backtrace@
 #define TS_HAS_PROFILER @has_profiler@
-#define TS_USE_GCOV @use_gcov@
 #define TS_USE_FAST_SDK @use_fast_sdk@
 #define TS_USE_DIAGS @use_diags@
 #define TS_USE_EPOLL @use_epoll@
diff --git a/proxy/Main.cc b/proxy/Main.cc
index 7512bfe..96c9f05 100644
--- a/proxy/Main.cc
+++ b/proxy/Main.cc
@@ -91,7 +91,6 @@ extern "C" int plock(int);
 #include "I_Tasks.h"
 #include "InkAPIInternal.h"
 #include "HTTP2.h"
-#include "ts/ink_config.h"
 
 #include <ts/ink_cap.h>
 
@@ -100,10 +99,6 @@ extern "C" int plock(int);
 #include <gperftools/heap-profiler.h>
 #endif
 
-#if TS_USE_GCOV
-extern "C" void __gcov_flush();
-#endif
-
 //
 // Global Data
 //
@@ -483,10 +478,6 @@ proxy_signal_handler(int signo, siginfo_t *info, void *ctx)
   ProfilerStop();
 #endif
 
-#if TS_USE_GCOV
-  __gcov_flush();
-#endif
-
   // We don't expect any crashing signals here because, but
   // forward to the default handler just to be robust.
   if (signal_is_crash(signo)) {

-- 
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" <commits@trafficserver.apache.org>.

Mime
View raw message