trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mas...@apache.org
Subject [trafficserver] branch quic-latest updated: Use the latest supported version number before version negotiation completes instead of 0
Date Tue, 09 Jan 2018 05:22:14 GMT
This is an automated email from the ASF dual-hosted git repository.

maskit pushed a commit to branch quic-latest
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/quic-latest by this push:
     new c68dd22  Use the latest supported version number before version negotiation completes
instead of 0
c68dd22 is described below

commit c68dd224475302476276616c1fe430662b635e4c
Author: Masakazu Kitajo <maskit@apache.org>
AuthorDate: Tue Jan 9 14:18:42 2018 +0900

    Use the latest supported version number before version negotiation completes instead of
0
    
    Version number 0 is reserved to represent version negotiation.
---
 iocore/net/quic/QUICPacket.cc | 1 -
 iocore/net/quic/QUICPacket.h  | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/iocore/net/quic/QUICPacket.cc b/iocore/net/quic/QUICPacket.cc
index c4f17e1..ba77577 100644
--- a/iocore/net/quic/QUICPacket.cc
+++ b/iocore/net/quic/QUICPacket.cc
@@ -794,7 +794,6 @@ QUICPacketFactory::_create_encrypted_packet(QUICPacketHeader *header,
bool retra
 void
 QUICPacketFactory::set_version(QUICVersion negotiated_version)
 {
-  ink_assert(this->_version == 0);
   this->_version = negotiated_version;
 }
 
diff --git a/iocore/net/quic/QUICPacket.h b/iocore/net/quic/QUICPacket.h
index 5f5d4f7..a392eb5 100644
--- a/iocore/net/quic/QUICPacket.h
+++ b/iocore/net/quic/QUICPacket.h
@@ -307,7 +307,7 @@ public:
   void set_crypto_module(QUICCrypto *crypto);
 
 private:
-  QUICVersion _version = 0;
+  QUICVersion _version = QUIC_SUPPORTED_VERSIONS[0];
   QUICCrypto *_crypto  = nullptr;
   QUICPacketNumberGenerator _packet_number_generator;
 

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <commits@trafficserver.apache.org>'].

Mime
View raw message