trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wka...@apache.org
Subject [trafficserver] branch master updated: Add thread yeield to avoid busy waiting in LogObject::_checkout_write(). (#7576)
Date Mon, 29 Mar 2021 12:45:57 GMT
This is an automated email from the ASF dual-hosted git repository.

wkaras pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new f278427  Add thread yeield to avoid busy waiting in LogObject::_checkout_write().
(#7576)
f278427 is described below

commit f278427b1ecdc5ce9e758de51a7faf83bcc58643
Author: Walt Karas <wkaras@verizonmedia.com>
AuthorDate: Mon Mar 29 07:45:41 2021 -0500

    Add thread yeield to avoid busy waiting in LogObject::_checkout_write(). (#7576)
---
 proxy/logging/LogObject.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/proxy/logging/LogObject.cc b/proxy/logging/LogObject.cc
index 9b8ec99..139dab7 100644
--- a/proxy/logging/LogObject.cc
+++ b/proxy/logging/LogObject.cc
@@ -39,6 +39,7 @@
 
 #include <algorithm>
 #include <vector>
+#include <thread>
 
 static bool
 should_roll_on_time(Log::RollingEnabledValues roll)
@@ -382,7 +383,9 @@ LogObject::_checkout_write(size_t *write_offset, size_t bytes_needed)
       break;
 
     case LogBuffer::LB_RETRY:
-      // no more room, but another thread should be taking care of creating a new buffer,
so try again
+      // no more room, but another thread should be taking care of creating a new buffer,
so yield to let
+      // the other thread finish, then try again
+      std::this_thread::yield();
       break;
 
     case LogBuffer::LB_BUFFER_TOO_SMALL:

Mime
View raw message